Skip to content

Remove unused &Camera in update_gizmo_meshes.#23853

Merged
alice-i-cecile merged 1 commit intobevyengine:mainfrom
andriyDev:no-cam-gizmo
Apr 17, 2026
Merged

Remove unused &Camera in update_gizmo_meshes.#23853
alice-i-cecile merged 1 commit intobevyengine:mainfrom
andriyDev:no-cam-gizmo

Conversation

@andriyDev
Copy link
Copy Markdown
Contributor

@andriyDev andriyDev commented Apr 17, 2026

Objective

Solution

  • Remove the arg! Replace with With<Camera>.

Testing

  • Ran the 3d_gizmos example. It still works!

@andriyDev andriyDev added D-Trivial Nice and easy! A great choice to get started with Bevy A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Apr 17, 2026
@github-project-automation github-project-automation bot moved this to Needs SME Triage in Rendering Apr 17, 2026
@andriyDev andriyDev requested a review from IceSentry April 17, 2026 07:52
tychedelia
tychedelia approved these changes Apr 17, 2026
View reviewed changes
Comment thread crates/bevy_gizmos_render/src/transform_gizmo_render.rs
focus: Option<bevy_ecs::system::Single<&GlobalTransform, With<TransformGizmoFocus>>>,
marked_cameras: Query<(&Camera, &GlobalTransform), With<TransformGizmoCamera>>,
marked_cameras: Query<&GlobalTransform, (With<TransformGizmoCamera>, With<Camera>)>,
all_cameras: Query<
Copy link
Copy Markdown
Member

@tychedelia tychedelia Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not your fault but an annoying name if these are disjoint lol

@andriyDev andriyDev added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Apr 17, 2026
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Apr 17, 2026
Merged via the queue into bevyengine:main with commit 724bc10 Apr 17, 2026
49 checks passed
@github-project-automation github-project-automation bot moved this from Needs SME Triage to Done in Rendering Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IceSentry IceSentry Awaiting requested review from IceSentry

1 more reviewer

@tychedelia tychedelia tychedelia approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

Rendering
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andriyDev @tychedelia @alice-i-cecile