Skip to content

Fix light bounding spheres being ambiguous with TransformSystems::Propagate.#23847

Merged
alice-i-cecile merged 1 commit intobevyengine:mainfrom
andriyDev:light-bounds-amb
Apr 17, 2026
Merged

Fix light bounding spheres being ambiguous with TransformSystems::Propagate.#23847
alice-i-cecile merged 1 commit intobevyengine:mainfrom
andriyDev:light-bounds-amb

Conversation

@andriyDev
Copy link
Copy Markdown
Contributor

@andriyDev andriyDev commented Apr 17, 2026

Objective

Solution

  • Explicitly order these lighting bounds updates after the transform propagation.

Testing

@andriyDev andriyDev added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Apr 17, 2026
@github-project-automation github-project-automation bot moved this to Needs SME Triage in Rendering Apr 17, 2026
@andriyDev andriyDev added C-Refinement Improves output quality, without fixing a clear bug or adding new functionality. and removed C-Bug An unexpected or incorrect behavior labels Apr 17, 2026
@andriyDev andriyDev requested a review from IceSentry April 17, 2026 07:52
Copy link
Copy Markdown
Member

@tychedelia tychedelia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a real bug?

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Apr 17, 2026
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Apr 17, 2026
Merged via the queue into bevyengine:main with commit 774e1fd Apr 17, 2026
51 checks passed
@github-project-automation github-project-automation bot moved this from Needs SME Triage to Done in Rendering Apr 17, 2026
@andriyDev andriyDev deleted the light-bounds-amb branch April 19, 2026 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Rendering Drawing game state to the screen C-Refinement Improves output quality, without fixing a clear bug or adding new functionality. D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants