Skip to content

feat: add cargo install fallback for dist prebuilt binary installation#2352

Open
ChanTsune wants to merge 1 commit intoaxodotdev:mainfrom
ChanTsune:feat/cargo-install-fallback
Open

feat: add cargo install fallback for dist prebuilt binary installation#2352
ChanTsune wants to merge 1 commit intoaxodotdev:mainfrom
ChanTsune:feat/cargo-install-fallback

Conversation

@ChanTsune
Copy link
Copy Markdown

When a prebuilt binary installer is unavailable for the target architecture (e.g. riscv), the generated CI workflow now falls back to cargo install cargo-dist --locked --version <version> instead of failing outright.

resolve #2351

When a prebuilt binary installer is unavailable for the target
architecture (e.g. riscv), the generated CI workflow now falls back
to `cargo install cargo-dist --locked --version <version>` instead
of failing outright.
@mistydemeo
Copy link
Copy Markdown
Contributor

I'm not sure if this is the right approach. This will catch any curl | sh failure, even ones that are unrelated to the installer being missing for a given architecture. I think it would make more sense to vary which install command we inject based on whether a binary should be available or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add cargo install fallback when prebuilt binary installer is unavailable

2 participants