fix(installer): skip checksum verification for custom download URLs#2344
Open
xingzihai wants to merge 1 commit intoaxodotdev:mainfrom
Open
fix(installer): skip checksum verification for custom download URLs#2344xingzihai wants to merge 1 commit intoaxodotdev:mainfrom
xingzihai wants to merge 1 commit intoaxodotdev:mainfrom
Conversation
When using a custom download URL (via env var), the checksum verification should be skipped because the checksum in the manifest is for the original binary, not the custom URL's binary. Issue: #18736
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18736
Problem
When using custom download URLs for installers, checksum verification was still being enforced, causing installation failures.
Solution
Modified the installer logic to skip checksum verification when a custom download URL is provided, allowing users to use their own hosting without checksum constraints.
Testing