Conversation
axlon
left a comment
There was a problem hiding this comment.
Hello, thank you for your PR. The patterns file is generated from Google's API so we shouldn't edit it directly. Instead what I think we should do is:
- Look for an override
- Look for an alias
- If there was an alias look for an override for that
- Use the original (or aliased) pattern
This would make the IC country code behave like all other country codes without having to maintain it separately
43ea662 to
0ad269b
Compare
0ad269b to
85af390
Compare
|
Hi @axlon, |
|
Seems Composer 2.9's new security features are messing with our older builds, I'll have a look at it when I find time and restart them. PR itself looks good to me 👍 |
|
Thank you for your contribution! |
|
This unfortunately won't match all Canary Islands Zip Codes. The source is wrong in saying that only 35 and 38 prefixes are used for Canary Islands. For example 49581 in Tenerife: |
|
Hi @iMusicJJ, I didn't update the PR description after receiving Axlon's feedback, but my changes no longer affect the source. |
Hi,
This pull request is related to #35.
Previously, I used this configuration to support the Canary Islands:
It allowed me to check codes like this:
However, it stopped working. after updating to v3.7.0+.
This PR restores that behaviour and makes the postal code pattern more restrictive, ensuring that only codes starting with 35 or 38 are considered valid (source).