fix: Handle calculations on data layers that disallow filters#2682
Open
Munksgaard wants to merge 1 commit intoash-project:mainfrom
Open
fix: Handle calculations on data layers that disallow filters#2682Munksgaard wants to merge 1 commit intoash-project:mainfrom
Munksgaard wants to merge 1 commit intoash-project:mainfrom
Conversation
Previously, adding calculations using `is_nil` on resources in data layers that
didn't support filtering, such as the one in the included test, the following
error was returned (at compile time if using `:auto` as the type, at runtime if
using `:boolean` as the type):
key :arguments not found in: is_nil(bookedInvoiceId)
Fix: remove the predicate exclusion from the hydrate_refs branch in
resolve_call. do_hydrate_refs already handles predicates correctly.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Munksgaard
changed the title
Function.new in resolve_call
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, adding calculations using
is_nilon resources in data layers thatdidn't support filtering, such as the one in the included test, the following
error was returned (at compile time if using
:autoas the type, at runtime ifusing
:booleanas the type):Fix: remove the predicate exclusion from the hydrate_refs branch in
resolve_call. do_hydrate_refs already handles predicates correctly.
Contributor checklist
Leave anything that you believe does not apply unchecked.