Skip to content

Add support for GCS.#1550

Open
lesaux wants to merge 4 commits intoaptly-dev:masterfrom
linuxdataflow:feat/pls/gcs-support
Open

Add support for GCS.#1550
lesaux wants to merge 4 commits intoaptly-dev:masterfrom
linuxdataflow:feat/pls/gcs-support

Conversation

@lesaux
Copy link
Copy Markdown

@lesaux lesaux commented Mar 28, 2026

Description of the Change

Adding support for GCS buckets.

Implementation trying to follow how it was done for s3.

Checklist

  • allow Maintainers to edit PR (rebase, run coverage, help with tests, ...)
  • unit-test added (if change is algorithm)
  • functional test added/updated (if change is functional)
  • man page updated (if applicable)
  • bash completion updated (if applicable)
  • documentation updated
  • [] author name in AUTHORS

@neolynx neolynx self-assigned this Mar 28, 2026
@neolynx neolynx requested a review from a team March 28, 2026 12:59
@neolynx neolynx added the needs rebase The PR needs to be rebased on master label Mar 28, 2026
@neolynx
Copy link
Copy Markdown
Member

neolynx commented Mar 28, 2026

Hi !

great work :-)

I tried to fix the pipeline issue on master, but was not able to rebase the branch on your repo. could you give maintainer access to your PR ?

@lesaux
Copy link
Copy Markdown
Author

lesaux commented Mar 28, 2026

Hi !

great work :-)

I tried to fix the pipeline issue on master, but was not able to rebase the branch on your repo. could you give maintainer access to your PR ?

Thank you!

I added you as a maintainer on my fork.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 9, 2026

Codecov Report

❌ Patch coverage is 12.94643% with 195 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.76%. Comparing base (1442651) to head (67a203d).

Files with missing lines Patch % Lines
gcs/public.go 11.11% 182 Missing and 2 partials ⚠️
context/context.go 0.00% 10 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1550      +/-   ##
==========================================
- Coverage   76.99%   75.76%   -1.24%     
==========================================
  Files         160      162       +2     
  Lines       14778    15002     +224     
==========================================
- Hits        11379    11366      -13     
- Misses       2266     2504     +238     
+ Partials     1133     1132       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@neolynx
Copy link
Copy Markdown
Member

neolynx commented Apr 12, 2026

I tried to rebase and push:

$ git push linuxdataflow -f feat/pls/gcs-support
ERROR: Permission to linuxdataflow/aptly.git denied to neolynx.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

I think you need to click a ckechbox in the PR itself, "Allow maintainers to acess and edit" or similar...

@lesaux
Copy link
Copy Markdown
Author

lesaux commented Apr 12, 2026

This is an org so I think I have to invite you to the repo.
I had invited you last week but I see the invitation expired.
I just invited you again. Let me know!

@neolynx
Copy link
Copy Markdown
Member

neolynx commented Apr 12, 2026

oh, I missed that... accepted now, thanks !

@neolynx neolynx force-pushed the feat/pls/gcs-support branch from ae6bfc6 to 67a203d Compare April 12, 2026 22:26
@neolynx neolynx added needs review Ready for review & merge and removed needs rebase The PR needs to be rebased on master labels Apr 12, 2026
@neolynx
Copy link
Copy Markdown
Member

neolynx commented Apr 12, 2026

rebased on master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs review Ready for review & merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants