CLI: Optimize generate_clients.py with dirs pruning#4243
Open
MonkeyCanCode wants to merge 2 commits intoapache:mainfrom
Open
CLI: Optimize generate_clients.py with dirs pruning#4243MonkeyCanCode wants to merge 2 commits intoapache:mainfrom
MonkeyCanCode wants to merge 2 commits intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR primary optimizes generate_clients.py with dirs pruning by using
os.walkas oppose torglob. The previous code scanned up to 6.4k files path and the updated one will scanned only ~250.Here is the old output (in verbose mode):
And the new output (in verbose mode) which we skipped a lot of those no-ops dirs/files:
Beside the above change, this PR also addresses couple NITs:
testtotestsas there is more than one test file now--global-property=apiDocs=false,modelDocs=false,modelTests=false,apiTests=false.openapi-generator-ignoreas bit to remove default comments and non-existed filesChecklist
CHANGELOG.md(if needed)site/content/in-dev/unreleased(if needed)