Sent Quick Start's Java link to the JDK download location.#5200
Open
InfamousPlatypus wants to merge 1 commit intoapache:masterfrom
Open
Sent Quick Start's Java link to the JDK download location.#5200InfamousPlatypus wants to merge 1 commit intoapache:masterfrom
InfamousPlatypus wants to merge 1 commit intoapache:masterfrom
Conversation
Sent Quick Start's Java link to the JDK download location. Should fix apache#5199
mrutkows
requested changes
Mar 17, 2022
| Serverless functions run within Docker containers. You will need [Docker](https://docs.docker.com/install), | ||
| [Java](https://java.com/en/download/help/download_options.xml) and [Node.js](https://nodejs.org) available on your machine. | ||
| Serverless functions run within Docker containers. You will need [Docker](https://docs.docker.com/install), the | ||
| [Java Development Kit](https://www.oracle.com/java/technologies/downloads/) and [Node.js](https://nodejs.org) available on your machine. |
Contributor
There was a problem hiding this comment.
Our policy is to reference OpenJDK as a basis and would also like to see a recommendation for a known, tested AdoptOpenJDK LTS version
Author
There was a problem hiding this comment.
I do have openJDK 11.0.11.9, it does not work and I don't know where it came from.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5200 +/- ##
==========================================
- Coverage 44.67% 44.07% -0.61%
==========================================
Files 238 238
Lines 13937 13957 +20
Branches 581 570 -11
==========================================
- Hits 6226 6151 -75
- Misses 7711 7806 +95 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changed the Java link from the JRE page to the JDK page.
Related issue and scope
#5199
My changes affect the following components
Types of changes
Checklist: