Skip to content

Support paramiko 4 changes#2135

Merged
micafer merged 1 commit intoapache:trunkfrom
s-t-e-v-e-n-k:support-paramiko-4
Apr 23, 2026
Merged

Support paramiko 4 changes#2135
micafer merged 1 commit intoapache:trunkfrom
s-t-e-v-e-n-k:support-paramiko-4

Conversation

@s-t-e-v-e-n-k
Copy link
Copy Markdown
Contributor

Support paramiko 4

Description

RSA key support has been removed as of paramiko 4, so only import it and check if the version number is less than 4.

Status

Replace this: describe the PR status. Examples:

  • done, ready for review

Checklist (tick everything that applies)

  • Code linting (required, can be done after the PR checks)
  • Documentation
  • Tests
  • ICLA (required for bigger changes)

@micafer
Copy link
Copy Markdown
Contributor

micafer commented Apr 22, 2026

@s-t-e-v-e-n-k , please review tests as they are failing.

RSA key support has been removed as of paramiko 4, so only import it and
check if the version number is less than 4.
@s-t-e-v-e-n-k
Copy link
Copy Markdown
Contributor Author

@s-t-e-v-e-n-k , please review tests as they are failing.

I have sorted out the failures and rebased for good measure.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 81.25000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.36%. Comparing base (f3af38f) to head (4e3c975).

Files with missing lines Patch % Lines
libcloud/test/compute/test_ssh_client.py 85.71% 0 Missing and 2 partials ⚠️
libcloud/compute/ssh.py 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            trunk    #2135      +/-   ##
==========================================
- Coverage   83.36%   83.36%   -0.00%     
==========================================
  Files         353      353              
  Lines       81906    81910       +4     
  Branches     9007     9010       +3     
==========================================
+ Hits        68278    68279       +1     
  Misses      10799    10799              
- Partials     2829     2832       +3     
Files with missing lines Coverage Δ
libcloud/compute/ssh.py 80.66% <50.00%> (-0.19%) ⬇️
libcloud/test/compute/test_ssh_client.py 96.10% <85.71%> (-0.42%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@micafer micafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@micafer micafer merged commit 52794f8 into apache:trunk Apr 23, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants