Merged
Conversation
raboof
reviewed
Aug 27, 2025
Member
raboof
left a comment
raboof
left a comment
There was a problem hiding this comment.
Note that the 'develop / build' CI job fails. You can click on it to see the error. Generally it's good practice to make CI succeed before requesting a review.
…ownClassSizerJUnitTest.java Co-authored-by: Arnout Engelen <arnout@engelen.eu>
raboof
approved these changes
Aug 27, 2025
Member
raboof
left a comment
raboof
left a comment
There was a problem hiding this comment.
looks good and no risk of regression (because it only changes the test), intending to merge when there's no unexpected CI failures
Contributor
Author
|
Thanks for your review, @raboof . I am glad to hear there's no risk of regression since the changes are limited to the test. |
6 tasks
JinwooHwang
added a commit
that referenced
this pull request
Sep 3, 2025
* WellKnownClassSizerJUnitTest * Update geode-core/src/test/java/org/apache/geode/internal/size/WellKnownClassSizerJUnitTest.java Co-authored-by: Arnout Engelen <arnout@engelen.eu> * WellKnownClassSizerJUnitTest --------- Co-authored-by: Arnout Engelen <arnout@engelen.eu> (cherry picked from commit 49b3434)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?