[Enrichment] Expose max_batch_duration_secs in SQL/BQ handlers (#38243)#38244
[Enrichment] Expose max_batch_duration_secs in SQL/BQ handlers (#38243)#38244prabhnoor0212 wants to merge 1 commit intoapache:masterfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the enrichment handlers for BigQuery and CloudSQL by exposing the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
5b4dc50 to
c9e1fa0
Compare
|
Assigning reviewers: R: @claudevdm for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
What changed
max_batch_duration_secspassthrough to PythonBigQueryEnrichmentHandlerbatching kwargs.CloudSQLEnrichmentHandlerbatching kwargs for table-based query configs.Why
Issue: #38243
Enrichmentforwards handler-provided batch kwargs toRequestResponseIO->BatchElements.Previously only min/max batch size were exposed by these handlers, so users could not configure
max_batch_duration_secsthrough them.