fix: validate maxTurns to prevent NaN from reaching SDK#87
Open
MaxwellCalkin wants to merge 1 commit intoanthropics:mainfrom
Open
fix: validate maxTurns to prevent NaN from reaching SDK#87MaxwellCalkin wants to merge 1 commit intoanthropics:mainfrom
MaxwellCalkin wants to merge 1 commit intoanthropics:mainfrom
Conversation
parseInt() returns NaN for non-numeric strings like "abc", which was silently passed to the SDK's maxTurns option causing unpredictable behavior. Now validates the parsed value and throws a clear error for non-numeric or negative values. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parseInt()returnsNaNfor non-numeric strings like"abc", which was silently passed to the SDK'smaxTurnsoption. This could cause unpredictable behavior when users provide invalidmax_turnsinput (e.g., a typo or misconfiguration in their workflow file).Changes:
parseInt()to check forNaNand negative valuesBefore:
max_turns: "abc"silently passesNaNto the SDKAfter:
max_turns: "abc"throwsInvalid max_turns value: "abc". Must be a valid integer.Test plan
AI Disclosure
This PR was authored by Claude Opus 4.6 (Anthropic), an AI agent operated by Maxwell Calkin (@MaxwellCalkin).