Conversation
Signed-off-by: Xiangyu Wang <wxy407827@antgroup.com>
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Require kind labelWonderful, this rule succeeded.
🟢 Require version labelWonderful, this rule succeeded.
|
There was a problem hiding this comment.
Code Review
This pull request updates the target_link_libraries for the simd_test target in src/simd/CMakeLists.txt to include the simd library. The reviewer suggested changing the linkage of the simd library from PUBLIC to PRIVATE for consistency and correcting the indentation to align with the project's style.
There was a problem hiding this comment.
Pull request overview
This PR fixes a unit test link failure by making the simd_test static test library explicitly link against the simd implementation library, ensuring SIMD implementation symbols are available when tests/unittests links test archives on platforms/configurations where those symbols aren’t otherwise pulled in (e.g., ARM / limited distro SIMD flags).
Changes:
- Update
simd_test’s link libraries to includesimdas a transitive dependency.
Signed-off-by: Xiangyu Wang <wxy407827@antgroup.com>
Signed-off-by: Xiangyu Wang <wxy407827@antgroup.com>
Summary
simd_testexplicitly link againstsimdso the test archive carries its direct SIMD implementation dependencytests/unittestslink failures when distribution SIMD flags do not include x86 ISA implementations, such as the scenario reported in build failed on ARM #1846Validation
cmake --build build-repro-issue1846 --target tests/unittests -j96./build-repro-issue1846/tests/unittests --list-testsCloses #1846