#167891607 Users should get stats of trips made in the last X timeframe#63
Open
#167891607 Users should get stats of trips made in the last X timeframe#63
Conversation
Pomile
requested review from
daniellamarr,
femitj,
max-wel,
meetKazuki and
tvpeter
Pomile
force-pushed
the
ft-get-tripsStatByTimeframe-endpoint-167891607
branch
3 times, most recently
from
f5e5d61 to
f45cb90
Compare
…t of trips made in last x timeframe - [x] Write test - [x] Validate timeframe(start and end date) - [x] Modified seeders - [x] Create a method that count trip request by time frame - [x] Create a route handler - [x] Write document with swagger [Finishes #167891607]
Pomile
force-pushed
the
ft-get-tripsStatByTimeframe-endpoint-167891607
branch
from
f45cb90 to
d938129
Compare
femitj
requested changes
Sep 17, 2019
Collaborator
femitj
left a comment
femitj
left a comment
There was a problem hiding this comment.
Can you limit the trips to only completed ones
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Have a user get the counts of trips made within a period
Description of Task to be completed?
How should this be manually tested?
Unit test
git pullgit checkoutft-get-tripsStatByTimeframe-endpoint-167891607`npm installdatabase_nameDevelopment test with Postman
npm run devstart/api/v1/trips/timeframe?start=2019-xx-xx&end='2019-xx-xxWhat are the relevant pivotal tracker stories?
#167891607
Any background context you want to add?
Nil
Screenshots