fix(security): 2 improvements across 2 files

[tomaioo]

Summary

fix(security): 2 improvements across 2 files

Problem

Severity: High | File: rock/sdk/builder/provider/dockerfile_builder.py:L36

The build_terminal_bench method writes files using untrusted keys from instance_record["files"] directly into f"{build_dir}/{file_name}" without path normalization or boundary checks. An attacker can provide filenames like ../../../../etc/cron.d/pwn to write outside build_dir, potentially overwriting arbitrary files on the host.

Solution

Normalize and validate each target path before writing. Use Path(build_dir) / file_name, resolve it, and enforce that it remains within build_dir (e.g., resolved_path.is_relative_to(build_dir_resolved) in Python 3.9+ equivalent logic). Reject absolute paths and parent traversal (..) segments.

Changes

• rock/sdk/builder/provider/dockerfile_builder.py (modified)
• rock/admin/scheduler/tasks/container_cleanup_task.py (modified)

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}