added api to fetchApprovedMcpServer#4832
Open
harshithb3304 wants to merge 3 commits intofeature/cyborg-releasefrom
Open
added api to fetchApprovedMcpServer#4832harshithb3304 wants to merge 3 commits intofeature/cyborg-releasefrom
harshithb3304 wants to merge 3 commits intofeature/cyborg-releasefrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for retrieving “approved MCP servers” from a new per-account MCP registry config via the database-abstractor API.
Changes:
- Adds
MCP_REGISTRYtoConfigTypeand introducesConfig.McpRegistryConfigwithregistriesandapprovedServersfields. - Adds a new Struts action route
api/fetchApprovedMcpServers. - Implements
DbAction.fetchApprovedMcpServers()and exposesapprovedMcpServersvia getter/setter.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| libs/dao/src/main/java/com/akto/dto/Config.java | Introduces McpRegistryConfig and new ConfigType.MCP_REGISTRY. |
| apps/database-abstractor/src/main/resources/struts.xml | Registers a new API action for fetching approved MCP servers. |
| apps/database-abstractor/src/main/java/com/akto/action/DbAction.java | Implements the API handler and response field for approved MCP servers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| public String fetchApprovedMcpServers() { | ||
| try { | ||
| int accountId = Context.accountId.get(); | ||
| String configId = accountId + "_MCP_REGISTRY"; |
Comment on lines
+577
to
+592
| public String fetchApprovedMcpServers() { | ||
| try { | ||
| int accountId = Context.accountId.get(); | ||
| String configId = accountId + "_MCP_REGISTRY"; | ||
| Config.McpRegistryConfig mcpRegistryConfig = (Config.McpRegistryConfig) ConfigsDao.instance.findOne( | ||
| com.mongodb.client.model.Filters.eq("_id", configId) | ||
| ); | ||
| if (mcpRegistryConfig != null) { | ||
| approvedMcpServers = mcpRegistryConfig.getApprovedServers(); | ||
| } | ||
| } catch (Exception e) { | ||
| loggerMaker.errorAndAddToDb(e, "error in fetchApprovedMcpServers " + e.toString()); | ||
| return Action.ERROR.toUpperCase(); | ||
| } | ||
| return Action.SUCCESS.toUpperCase(); | ||
| } |
|
|
||
| public McpRegistryConfig(int accountId) { | ||
| this.configType = ConfigType.MCP_REGISTRY; | ||
| this.id = accountId + "_MCP_REGISTRY"; |
…improved clarity and maintainability
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.