Skip to content

Slightly simplify ci.style job#297

Merged
ulgens merged 2 commits intomainfrom
simplify-ci-lint
Apr 14, 2026
Merged

Slightly simplify ci.style job#297
ulgens merged 2 commits intomainfrom
simplify-ci-lint

Conversation

@ulgens
Copy link
Copy Markdown
Collaborator

@ulgens ulgens commented Apr 14, 2026

@ulgens ulgens requested a review from agriyakhetarpal April 14, 2026 09:40
@ulgens ulgens force-pushed the simplify-ci-lint branch from 2ece0ac to 9c46d55 Compare April 14, 2026 09:41
@ulgens
Copy link
Copy Markdown
Collaborator Author

ulgens commented Apr 14, 2026

@agriyakhetarpal Do we want to lint submodules? I feel like submodules: recursive can be removed from the checkout.

Copy link
Copy Markdown
Owner

@agriyakhetarpal agriyakhetarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀✨

@agriyakhetarpal
Copy link
Copy Markdown
Owner

@agriyakhetarpal Do we want to lint submodules? I feel like submodules: recursive can be removed from the checkout.

Oh, we need it for the Hugo source code to be checked out, actually. It's what we build against :)

@agriyakhetarpal
Copy link
Copy Markdown
Owner

I previously used a git clone command in the setup code for this, and the reason to make the switch was that it's easier for Piwheels this way (it doesn't allow Git usage). I still have to check if that succeeded or not.

@ulgens
Copy link
Copy Markdown
Collaborator Author

ulgens commented Apr 14, 2026

we need it for the Hugo source code to be checked out, actually.

I see, but is it needed for the lint step? I wasn't planning to touch the checkout details on the build_wheels step.

@agriyakhetarpal
Copy link
Copy Markdown
Owner

Ah, thanks for clarifying. No, we don't need it for the lint step – that was probably a mistake from me!

@ulgens ulgens merged commit 2ed0fa5 into main Apr 14, 2026
28 checks passed
@ulgens ulgens deleted the simplify-ci-lint branch April 14, 2026 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants