Skip to content

fix: NULL embeddings bug#7566

Open
pecastro wants to merge 2 commits intoagno-agi:mainfrom
pecastro:null-embedding-bug
Open

fix: NULL embeddings bug#7566
pecastro wants to merge 2 commits intoagno-agi:mainfrom
pecastro:null-embedding-bug

Conversation

@pecastro
Copy link
Copy Markdown

@pecastro pecastro commented Apr 17, 2026

Summary

This fix ensures that NULL embedding don't make it to the DB in case of excessive 429 errors when the embedder is running with enable_batch false.
In scenarios where the embedder endpoint is overloaded, returning 429s and the httpx instance exhausts it's max_retries count, this bug was being responsible for the creation of DB records whose embeddings field was NULL.

(If applicable, issue number: #7567)

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Improvement
  • Model update
  • Other:

Checklist

  • Code complies with style guidelines
  • Ran format/validation scripts (./scripts/format.sh and ./scripts/validate.sh)
  • Self-review completed
  • Documentation updated (comments, docstrings)
  • Examples and guides: Relevant cookbook examples have been included or updated (if applicable)
  • Tested in clean environment
  • Tests added/updated (if applicable)

Duplicate and AI-Generated PR Check

  • I have searched existing open pull requests and confirmed that no other PR already addresses this issue
  • If a similar PR exists, I have explained below why this PR is a better approach
  • Check if this PR was entirely AI-generated (by Copilot, Claude Code, Cursor, etc.)

Additional Notes

Add any important context (deployment instructions, screenshots, security considerations, etc.)

- Prevent writing NULL embeddings when per-doc async embedding hits 429 by re-raising after gather
@pecastro pecastro requested a review from a team as a code owner April 17, 2026 17:26
@github-actions
Copy link
Copy Markdown
Contributor

PR Triage

Missing issue link: Please link the issue this PR addresses using fixes #<issue_number>, closes #<issue_number>, or resolves #<issue_number> in the PR description. If there is no existing issue, please create one first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant