Open
Conversation
- Prevent writing NULL embeddings when per-doc async embedding hits 429 by re-raising after gather
Contributor
PR TriageMissing issue link: Please link the issue this PR addresses using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fix ensures that NULL embedding don't make it to the DB in case of excessive 429 errors when the embedder is running with enable_batch false.
In scenarios where the embedder endpoint is overloaded, returning 429s and the httpx instance exhausts it's max_retries count, this bug was being responsible for the creation of DB records whose embeddings field was NULL.
(If applicable, issue number: #7567)
Type of change
Checklist
./scripts/format.shand./scripts/validate.sh)Duplicate and AI-Generated PR Check
Additional Notes
Add any important context (deployment instructions, screenshots, security considerations, etc.)