Prevent querying all clients in client composite import#1292
Prevent querying all clients in client composite import#1292adhurjaty wants to merge 3 commits intoadorsys:mainfrom
Conversation
|
adhurjaty
changed the title
AssahBismarkabah
added
enhancement
java
adhurjaty
force-pushed
the
improve-client-composite-import-runtime
branch
from
8692fb4 to
3ec707e
Compare
|
Motouom
requested review from
AssahBismarkabah and
Nkwenti-Severian-Ndongtsop
Nkwenti-Severian-Ndongtsop
left a comment
Nkwenti-Severian-Ndongtsop
left a comment
There was a problem hiding this comment.
hello @adhurjaty
Please can you resolve your conflicts ??
adhurjaty
force-pushed
the
improve-client-composite-import-runtime
branch
from
3ec707e to
01f03e1
Compare
|
Looks like test coverage is slightly under the threshold for 25.0.1. I don't have access to the coverage tool, so it's not easy for me to figure out where the gaps I'd need to fill are. Can someone help out with this? |
|
Thanks, @adhurjaty, for the quick feedback |
adhurjaty
force-pushed
the
improve-client-composite-import-runtime
branch
from
39d2b58 to
5c19fb0
Compare
|
|
@adhurjaty, Your changes bring in some conflicts |
adhurjaty
force-pushed
the
improve-client-composite-import-runtime
branch
2 times, most recently
from
346d9d5 to
09430c7
Compare
Signed-off-by: Anil Dhurjaty <anil.dhurjaty@appfolio.com>
adhurjaty
force-pushed
the
improve-client-composite-import-runtime
branch
from
1d08a13 to
604e3c7
Compare
|
4 participants
What this PR does / why we need it:
As the number of clients in our realms increases, we noticed that the time to run the configuration job increased as well, even though we were omitting the clients from the config JSON. We noticed that the
RoleImportServicestep was taking a much longer time than the other steps.This change updates the
RealmCompositeRepositoryto instead get the realm composites and query the clients based on that, instead of getting all the clients and checking against theRoleResourceto see if it is a composite. This results in a much faster execution of the role import step.This change updates the
ClientCompositeImportservices to more efficiently remove composites that need to be removed. The current method gets all clients and excludes config import client composites, then gets the intersection between that and the existing client composites. The proposed change simply retrieves the existing client composites and excludes the config client compositesCurrent
Proposed
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR