Fix matrix parsing.#570
Open
pokebadgerswithspoon wants to merge 1 commit intoadobe-webplatform:devfrom
Open
Conversation
Space symbol in front of matrix was treated an extra paramter This used to work just like expected Was: matrix(0.5,0,0,0.5, 0,0) snap.svg.js:2814 Became: m,0.5,0,0,0.5,0,0 snap.svg.js:2816 This was handled incorrectly Was: matrix( 1, 0, 0, 1, 50.45,55.65) snap.svg.js:2814 Became: m,,1,0,0,1,50.45,55.65 snap.svg.js:2816 Mark double comma! This commit trims all the whitespace within bracket content
|
Hey @pokebadgerswithspoon - your build was failing for the same reason as mine, some code formatting in equal.js that grunt had no problem with but the cli did. I updated the equal.js file in #581 and my build is passing fine. If you follow the code there it should also let your build pass 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blank symbol in front of matrix was treated an extra paramter.
This commit trims all the whitespace around content of brackets.
Example
This was handled incorrectly
Was: matrix( 1, 0, 0, 1, 50.45,55.65) snap.svg.js:2814
Became: m,,1,0,0,1,50.45,55.65 snap.svg.js:2816
Mark the double comma!
SVG
To test a bug you need to create an html file with SVG content which has matrix transform, say scaled 50%.
Wrap it with Snap, select transformed element and try to rotate it. Scale will reset to 100%.
Check example below and note space in front of 0.5.
<g transform="matrix( 0.5,0,0,0.5, 0,0) " id="content">....something simple yo'd like to rotate...</g>