Fix command line for evaluating rot+kp PHC3 model on AMASS #159
Open
IsshikiHugh wants to merge 2 commits intoZhengyiLuo:masterfrom
Open
Fix command line for evaluating rot+kp PHC3 model on AMASS #159IsshikiHugh wants to merge 2 commits intoZhengyiLuo:masterfrom
IsshikiHugh wants to merge 2 commits intoZhengyiLuo:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @ZhengyiLuo ,
Thanks for your super cool project! However, I met a problem during inspecting the code, and I did some walkaround to make it works (at least for me). Hope them help!
This PR contains two changes:
README.md. (Automatically done by my editor, I think it's beneficial overall, so I keep it.)They are committed separately, you can check the second commit directly for the change that matters.
Here are some explanation about the modifications.
PHC/README.MD
Lines 234 to 235 in 846988d
Unfolding this command line, we will have:
python phc/run_hydra.py \ learning=im_mcp_big \ exp_name=phc_comp_3 \ env=env_im_getup_mcp \ robot=smpl_humanoid \ env.zero_out_far=False robot.real_weight_porpotion_boxes=False \ env.num_prim=3 \ env.motion_file=sample_data/amass_isaac_standing_upright_slim.pkl \ env.models=['output/HumanoidIm/phc_3/Humanoid.pth'] \ env.num_envs=1 \ headless=False \ im_eval=TrueBut when I run this command, it just fails to give correct results. Each agent just fell to the ground and can't get up. Which acts like the command actually launches a training. Then I did some walkaround.
Compared to other evaluation command on AMASS, e.g.:
PHC/README.MD
Lines 238 to 239 in 846988d
python phc/run_hydra.py \ learning=im_mcp \ exp_name=phc_shape_mcp_iccv \ + epoch=-1 \ + test=True \ env=env_im_getup_mcp \ robot=smpl_humanoid_shape \ robot.freeze_hand=True \ robot.box_body=False \ env.z_activation=relu \ env.motion_file=sample_data/amass_isaac_standing_upright_slim.pkl \ env.models=['output/HumanoidIm/phc_shape_pnn_iccv/Humanoid.pth'] \ env.num_envs=1 \ headless=False \ im_eval=TrueI think the
epoch=-1andtest=Trueare needed but are missing. After adding these two, the results seem correct for me.Thank you very much!