Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To update the documentation on yarnspinner.dev, please visit the documentation repository.
What is the current behavior? (You can also link to an open issue here)
More details in Language Server: Command to apply line tags IssuesDiscussion#24 but it'd be nice to apply missing line tags directly from the VS code extension (via the language server). Currently need to use unity, the ysc tool, or add line tags manually.
What is the new behavior (if this is a feature change)?
This PR adds a TagLines command to the language server that takes in a link to a project (or a file in a project) and returns a workspace edit with all the text edits needed to add line tags to every untagged line in the project.
Does this pull request introduce a breaking change? (What changes might users need to make in their application due to this PR?)
None!
Other information:
Starting this out as a draft PR until tests are added