[NEEDS_REVIEW] Upstream sync v3.17.0 → v3.17.4#13
Draft
github-actions[bot] wants to merge 1 commit intodevfrom
Draft
[NEEDS_REVIEW] Upstream sync v3.17.0 → v3.17.4#13github-actions[bot] wants to merge 1 commit intodevfrom
github-actions[bot] wants to merge 1 commit intodevfrom
Conversation
github-actions
Bot
force-pushed
the
sync/upstream/v3.17.4-needs-review
branch
24 times, most recently
from
a75f976 to
6203396
Compare
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
github-actions
Bot
force-pushed
the
sync/upstream/v3.17.4-needs-review
branch
from
6203396 to
8a287df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft PR for the NEEDS_REVIEW batch of upstream v3.17.0 →
sync/upstream/v3.17.4-needs-review.This PR is not auto-mergeable. Phase 1 of the upstream-analyzer pipeline is advisory only.
Commits in this batch
1e2e0019refactor(create-tools): keep result type internal -- The commit changes the export status ofCreateToolsResultwithout clear justification or visible callers in the diff, requiring further investigation to determine impact.9d89bbb0refactor(commands): keep builtin command options internal -- The commit changes the export status of an interface without clear justification or visible callers in the diff.Analysis: #12
Summary by cubic
Sync to upstream v3.17.4, keep internal-only types out of the public API, and unify null checks to
== nullin env expansion and the background-agent loop detector. External imports ofCreateToolsResultandLoadBuiltinCommandsOptionsmay break.CreateToolsResultinternal insrc/create-tools.tsandLoadBuiltinCommandsOptionsinternal insrc/features/builtin-commands/commands.ts.== nullinclaude-code-mcp-loader/env-expanderand the loop detector (incl.sortObject).Written for commit 8a287df. Summary will update on new commits.