fix: add box shadow instead of outline for all focusable elements and some spacing to the elements#552
Merged
samcunliffe merged 2 commits intoUCL-ARC:mainfrom Jun 17, 2025
Conversation
…d some extra spacing to the elements
samcunliffe
approved these changes
Jun 17, 2025
Member
samcunliffe
left a comment
samcunliffe
left a comment
There was a problem hiding this comment.
🚀 Another great fix! Thanks so much!!
| box-shadow: 0 0 0 3px var(--outline-color); | ||
| border-radius: 2px; | ||
| transition: box-shadow 0.2s ease; | ||
| } |
Member
There was a problem hiding this comment.
Confirmed fix of
For example:
C.f. James' original comment and screenshots in #534. (Also apparent in the video!)
samcunliffe
added
enhancement
paddyroddy
approved these changes
Jun 17, 2025
| $blue-400: #4da6ff; | ||
| $green-700: #00755c; | ||
| $red-600: #d13c3c; | ||
| $purple-500: rgba(215, 186, 255, 0.65); |
Member
There was a problem hiding this comment.
Out of interest why rgba here rather than a HEX?
Contributor
Author
There was a problem hiding this comment.
Sure. I used rgba because it’s easier to adjust the opacity by changing the last argument. There’s also the option to use hex with alpha, like #d13c3c65, where the last two control opacity. However, I’m not sure about browser support for that, and I’ve just got used to using rgba in these cases)
| } | ||
| } | ||
|
|
||
| //Outline styles |
Member
There was a problem hiding this comment.
I would tend to put a space here
Suggested change
| //Outline styles | |
| // Outline styles |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves focus visibility
Issues
Changes
screen-recording-2025-06-16-at-134028_DuMjmcNW.mp4
Closes #536, #534