Add a Makefile for Ruby/bundle/Jekyll commands that I always forget.#551
Conversation
There was a problem hiding this comment.
Pull Request Overview
Adds a Makefile under docs/ to streamline common Jekyll tasks and updates the contributing guide to use make serve instead of manual bundle commands.
- Introduces
docs/Makefilewith targets: help, serve, build, install, clean, check - Updates
CONTRIBUTING.mdto referencemake servefor local builds
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| docs/Makefile | New Makefile providing shortcuts for Jekyll commands |
| CONTRIBUTING.md | Switched manual bundle commands to make serve instructions |
Comments suppressed due to low confidence (2)
docs/Makefile:23
- [nitpick] The error message suggests installing Ruby but the check is for the
bundlecommand; consider clarifying it to mention installing Bundler or including a check for Jekyll itself.
@command -v bundle &> /dev/null || { echo >&2 "Please install ruby >= 2.7 to use Jekyll"; exit 1; }
docs/Makefile:4
- Ensure all Makefile command lines are indented with a tab character (not spaces) to avoid parsing errors.
@echo
| @@ -0,0 +1,23 @@ | |||
| SHELL := /bin/bash | |||
|
|
|||
| help: ## Show this help | |||
There was a problem hiding this comment.
Add a .PHONY declaration (e.g., .PHONY: help serve build install clean check) after the SHELL assignment to prevent conflicts if files with matching names exist.
paddyroddy
left a comment
There was a problem hiding this comment.
Can I offer a simpler solution? https://github.com/paddyroddy/paddyroddy.github.io/blob/main/_deploy.sh
But then I have to remember the name of the script. Is it |
|
|
For an n+1 option that scientific python folks are using, see https://pypi.org/project/spin/ |
|
Oh wow. I didn't realise this would be a controversial one. Sorry for the merge without two reviewers. Talk at FOSDEM Python session about how cool Makefiles can be. |
|
FWIW I'm 👍 for |
In what world is |
Editing the file. The |
I can never remember how to build the pages. Perhaps
makehelps? Certainly, it will positively affect all the carbon I'm wasting by Googling this: Every. Single. Time.With no arguments it shows help:
And
make servedoes what 90% of developers are going to want for checking local changes.Inspired by (and a little bit stolen from) @t-young31 and @milanmlft (who are both very cool).