Explain table WikiText handling TODO comment#9803
Open
andrewgoz wants to merge 4 commits intoTiddlyWiki:masterfrom
Open
Explain table WikiText handling TODO comment#9803andrewgoz wants to merge 4 commits intoTiddlyWiki:masterfrom
andrewgoz wants to merge 4 commits intoTiddlyWiki:masterfrom
Conversation
❌ Deploy Preview for tiddlywiki-previews failed. Why did it fail? →
|
|
Confirmed: andrewgoz has already signed the Contributor License Agreement (see contributing.md) |
📊 Build Size Comparison:
|
| Branch | Size |
|---|---|
| Base (master) | 2488.9 KB |
| PR | 2489.0 KB |
Diff: ⬆️ Increase: +0.1 KB
✅ Change Note Status
All change notes are properly formatted and validated!
📝 $:/changenotes/5.4.0/#9803
Type: enhancement | Category: usability
Release: 5.4.0
Re-enable WikiText table caption positioning
🔗 #9803
👥 Contributors: andrewg_oz
📖 Change Note Guidelines
Change notes help track and communicate changes effectively. See the full documentation for details.
andrewgoz
commented
Apr 14, 2026
Contributor
Author
andrewgoz
left a comment
andrewgoz
left a comment
There was a problem hiding this comment.
Added release note
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The caption processing is best explained using two WikiText tables:
and
in both cases the HTML
<caption>element is made the first child of the<table>element - as it should be.I also changed the
slice()tounshift(), because I find the latter more clear. The comment associated with that was simply wrong.