Open
Conversation
The TOC chevron buttons contain only an SVG icon with no accessible name. Screen readers announce them as bare "button" with no hint of purpose, making keyboard/screen-reader navigation of the sidebar table of contents impossible. Added aria-label="expand" and aria-label="collapse" to all 10 toggle buttons across the four expandable TOC body procedures. Uses plain English strings for now — proper i18n via language tiddlers can follow as a separate task. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Move expand/collapse buttons out of link elements in linked TOC variants so screen readers announce them as separate interactive controls instead of merging button and link text. - Move buttons outside $link in toc-linked-expandable-body and toc-linked-selective-expandable-body - Add dynamic aria-labels with tiddler title (e.g. "expand Introduction") - Add tabindex="-1" to blank placeholder buttons to skip them in tab order - Wrap button+link in div.tc-toc-item-row to preserve tabbed TOC styling - Restyle tabbed TOC CSS to target .tc-toc-item-row instead of > a Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
✅ Deploy Preview for tiddlywiki-previews ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Confirmed: pmario has already signed the Contributor License Agreement (see contributing.md) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the TOC empty button problem mentioned in issue