Add Docker support with docker-compose and automated release workflow#9753
Add Docker support with docker-compose and automated release workflow#9753NotHimmel wants to merge 9 commits intoTiddlyWiki:masterfrom
Conversation
- Add Dockerfile (Node Alpine, unprivileged user, configurable via env vars) - Add docker-compose.yml with named volume and environment variable support - Add docker/entrypoint.sh for wiki init and --listen argument assembly - Add bin/docker-publish.sh for manual multi-platform image publishing - Add .github/workflows/docker-publish.yml for automated Docker Hub release on GitHub Release publish - Add editions/tw5.com howto tiddler documenting Docker usage Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
@NotHimmel It appears that this is your first contribution to the project, welcome. With apologies for the bureaucracy, please could you prepare a separate PR to the 'tiddlywiki-com' branch with your signature for the Contributor License Agreement (see contributing.md). |
|
✅ Deploy Preview for tiddlywiki-previews ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
NotHimmel has signed the Contributor License Agreement (see contributing.md) |
pmario
left a comment
There was a problem hiding this comment.
@Jermolene @saqimtiaz ... IMO we should publish our official TW for docker image
| uses: docker/login-action@v3 | ||
| with: | ||
| username: ${{ secrets.DOCKERHUB_USERNAME }} | ||
| password: ${{ secrets.DOCKERHUB_TOKEN }} |
There was a problem hiding this comment.
@Jermolene, this will require, that we have a proper Setup at DockerHub - Which we should have.
Secrets have to be properly setup here in the repo
Co-authored-by: Mario Pietsch <pmariojo@gmail.com>
Co-authored-by: Mario Pietsch <pmariojo@gmail.com>
Co-authored-by: Mario Pietsch <pmariojo@gmail.com>
Co-authored-by: Mario Pietsch <pmariojo@gmail.com>
Co-authored-by: Mario Pietsch <pmariojo@gmail.com>
Co-authored-by: Mario Pietsch <pmariojo@gmail.com>
Co-authored-by: Mario Pietsch <pmariojo@gmail.com>
|
@pmario I think the howto tiddler is meant for contributors reading the source, not for use inside the container — so that part doesn't belong in the Docker image. |
Limit the Docker build context to the files needed for the server container so demos, tests and unrelated editions are excluded from the image. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
@pmario How's it going? |
|
@NotHimmel ... Docker images can only be created once a TW version has been published. So we need to develop a way that makes that possible. v5.4.0 is planned to be published 20th April |
Resolves #7387