Open
Conversation
…onEnd
Use $tw.utils.convertEventName("animationEnd") and add pulse CSS animation
Fixes TiddlyWiki#6835
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
✅ Deploy Preview for tiddlywiki-previews ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Confirmed: pmario has already signed the Contributor License Agreement (see contributing.md) |
📊 Build Size Comparison:
|
| Branch | Size |
|---|---|
| Base (master) | 2487.2 KB |
| PR | 2487.4 KB |
Diff: ⬆️ Increase: +0.2 KB
⚠️ Change Note Status
This PR appears to contain code changes but doesn't include a change note.
Please add a change note by creating a .tid file in editions/tw5.com/tiddlers/releasenotes/<version>/
📚 Documentation: Release Notes and Changes
💡 Note: If this is a documentation-only change, you can ignore this message.
Member
Author
|
@Jermolene ... I did manually test the function and it works for me. Then I did instruct Claude to create a new branch. Make a commit with a commit message. Push and create a new PR with the OP text. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
$tw.utils.pulseElement()— replace missing$tw.browser.animationEndProblem
$tw.utils.pulseElement()has been broken because it references$tw.browser.animationEnd, which was removed from the core and isundefined. The function silently fails — the event listener never fires, so thepulseCSS class is never cleaned up. Additionally, no.pulseCSS class was defined in the vanilla theme.Fixes #6835
Changes
core/modules/utils/dom/dom.js— Replace$tw.browser.animationEndwith$tw.utils.convertEventName("animationEnd"), which already exists in the core and correctly resolves browser-specific animation end event names.themes/tiddlywiki/vanilla/base.tid— Add.pulseCSS class and@keyframes pulseanimation (lightgreen background flash, opacity 0.3→1 over 0.8s).How to use
$tw.utils.pulseElement()is a debugging utility. It briefly highlights a DOM element with a green flash to help visualise which nodes are being rendered or refreshed.Browser console:
From widget code (e.g. in a
renderorrefreshmethod):This is particularly useful when debugging widget refresh behaviour — add
$tw.utils.pulseElement(this.domNodes[0])to a widget'srefresh()method to see exactly when and which elements get refreshed.🤖 Generated with Claude Code