This repository was archived by the owner on Dec 24, 2024. It is now read-only.
fix: fix undefined variable targetId#120
Open
vermaysha wants to merge 1 commit intoTheRealJoelmatic:mainfrom
Open
fix: fix undefined variable targetId#120vermaysha wants to merge 1 commit intoTheRealJoelmatic:mainfrom
vermaysha wants to merge 1 commit intoTheRealJoelmatic:mainfrom
Conversation
BlueWorld1
reviewed
Jan 13, 2024
| if (element.getAttribute("id") === "panels") { | ||
| element.childNodes?.forEach((childElement) => { | ||
| if (childElement.data.targetId && childElement.data.targetId !=="engagement-panel-macro-markers-description-chapters") | ||
| if (childElement.data?.targetId && childElement.data.targetId !=="engagement-panel-macro-markers-description-chapters") |
Contributor
There was a problem hiding this comment.
Suggested change
| if (childElement.data?.targetId && childElement.data.targetId !=="engagement-panel-macro-markers-description-chapters") | |
| if (childElement?.data?.targetId !=="engagement-panel-macro-markers-description-chapters") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure if this fix is necessary or not, but since I'm not comfortable looking at the console.log which has a lot of error messages, I made this fix.