Block and Inline: Enhance explanation of div and span elements#30638
Block and Inline: Enhance explanation of div and span elements#30638dayview wants to merge 7 commits intoTheOdinProject:mainfrom
Conversation
clarified the roles of div and span elements in HTML, what they "actually" do as generic containers for styling and layout. highlighting the main differences in design behavior between block-level and inline elements
ManonLef
left a comment
There was a problem hiding this comment.
Thanks @dayview ! Overall I think this is worded more beginner friendly, and it definitely reads much nicer. Seems like a good improvement to me.
I did leave some comments with suggestions.
Overall I dialed down the bold and italic styling. It doesn't fit well with how we generally use those in the lessons or even in this lesson. Block and inline for example have been covered and don't need emphasis.
Co-authored-by: Manon <81025586+ManonLef@users.noreply.github.com>
|
Hi @ManonLef! Thank you so much for the feedback! I understand I went overboard with the formatting, and I wanted to try using the convention usually for wordings to the past modules/lessons. Since block and inline were already covered earlier, they don't need additional emphasis here. I'll update the PR to keep the formatting cleaner and more consistent with the rest of the curriculum. |
Co-authored-by: Manon <81025586+ManonLef@users.noreply.github.com>
Co-authored-by: Manon <81025586+ManonLef@users.noreply.github.com>
Co-authored-by: Manon <81025586+ManonLef@users.noreply.github.com>
Co-authored-by: Manon <81025586+ManonLef@users.noreply.github.com>
Co-authored-by: Manon <81025586+ManonLef@users.noreply.github.com>
Because
The original lesson text is technically accurate but doesn't give readers concrete examples of what
divandspanare or when to use them. It also jumps between concepts (generic containers, hooks, grouping, block-level) without clearly explaining the problem they solve or how they differ in practical use.This PR
divandspanwith clear behavior descriptions (block vs inline)divandspanare used (e.g., cards, styling a single word)divandspanrelate to the block vs inline conceptdivandspanin their projectsIssue
No related PR
Additional Information
Pull Request Requirements
location of change: brief description of changeformat, e.g.Intro to HTML and CSS lesson: Fix link textBecausesection summarizes the reason for this PRThis PRsection has a bullet point list describing the changes in this PRIssuesection