Open
Conversation
No need for a full handholdy tutorial. Just highlight the differences between stateful/stateless and session/JWT
req.headers is a Node built-in getter as part of the Message interface (which extends Request). Not as intuitive to find docs for since people will likely look at the Request interface first. It'll be easier for learners to find an Express method in Express docs - consistent with other Express methods used in this and other lessons.
More detail left for a future Sessions vs JWTs lesson
Zadag
reviewed
May 18, 2025
Contributor
Zadag
left a comment
Zadag
left a comment
There was a problem hiding this comment.
Various grammar and tonal improvements.
Co-authored-by: Kevin Browne <kbrowne97@gmail.com>
01zulfi
added
the
Project Node Revamp
01zulfi
requested changes
May 24, 2025
Member
01zulfi
left a comment
01zulfi
left a comment
There was a problem hiding this comment.
Looking real good, just a few comments below
Content to be covered in a later planned lesson.
Closer parallel with sessions example, only omitting DB query for session
Contributor
Author
|
@01zulfi Just realised with the caveats section gone, there's nothing about logging out with stateless auth. Added a little bit about logging out but leaving the caveat details for the comparison lesson. This little bit should be sufficient and allow the learner to figure out what code they might need based on the mechanism. |
jwt.io now has a slightly different decoder/encoder interface.
Better matches style guide's intent for the section: https://github.com/TheOdinProject/curriculum/blob/main/LAYOUT_STYLE_GUIDE.md#lesson-layout
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
As part of the Node revamp's 2nd milestone
This PR
Issue
Closes #29519
Additional Information
Pull Request Requirements
location of change: brief description of changeformat, e.g.Intro to HTML and CSS lesson: Fix link textBecausesection summarizes the reason for this PRThis PRsection has a bullet point list describing the changes in this PRIssuesection