Skip to content

Master#14573

Closed
ligumas wants to merge 1 commit intoTheAlgorithms:masterfrom
ligumas:master
Closed

Master#14573
ligumas wants to merge 1 commit intoTheAlgorithms:masterfrom
ligumas:master

Conversation

@ligumas
Copy link
Copy Markdown

@ligumas ligumas commented Apr 22, 2026

###Describe your change:

Add an algorithm?
Fix a bug or typo in an existing algorithm?
Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
Documentation change?

Checklist:

I have read CONTRIBUTING.md.
This pull request is all my own work -- I have not plagiarized.
I know that pull requests will not be merged if they fail the automated tests.
This PR only changes one algorithm file. (Note: this PR modifies documentation and adds a test file.)
All new Python files are placed inside an existing directory.
All filenames are in all lowercase characters with no spaces or dashes.
All functions and variable names follow Python naming conventions.
All function parameters and return values are annotated with Python type hints.
All functions have doctests that pass the automated testing.
All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword (e.g. Fixes #123).

Short summary:

Added a short usage example to README.md and a simple unit test test_count_number_of_one_bits.py.

What changed and why:

What: Added an example and a small unittest for the set-bits functions; did not change algorithm logic in count_number_of_one_bits.py. The main function shown is 

get_set_bits_count_using_brian_kernighans_algorithm.
Why: Improve discoverability and add a lightweight regression test to catch future breakages.
Impact: Documentation + test only; no functional changes.

###Describe your change:

    Add an algorithm?
    Fix a bug or typo in an existing algorithm?
    Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
    Documentation change?

Checklist:

    I have read CONTRIBUTING.md.
    This pull request is all my own work -- I have not plagiarized.
    I know that pull requests will not be merged if they fail the automated tests.
    This PR only changes one algorithm file. (Note: this PR modifies documentation and adds a test file.)
    All new Python files are placed inside an existing directory.
    All filenames are in all lowercase characters with no spaces or dashes.
    All functions and variable names follow Python naming conventions.
    All function parameters and return values are annotated with Python type hints.
    All functions have doctests that pass the automated testing.
    All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
    If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword (e.g. Fixes #123).

Short summary:

    Added a short usage example to README.md and a simple unit test test_count_number_of_one_bits.py.

What changed and why:

    What: Added an example and a small unittest for the set-bits functions; did not change algorithm logic in count_number_of_one_bits.py. The main function shown is

get_set_bits_count_using_brian_kernighans_algorithm.
Why: Improve discoverability and add a lightweight regression test to catch future breakages.
Impact: Documentation + test only; no functional changes.
@algorithms-keeper
Copy link
Copy Markdown

Closing this pull request as invalid

@ligumas, this pull request is being closed as none of the checkboxes have been marked. It is important that you go through the checklist and mark the ones relevant to this pull request. Please read the Contributing guidelines.

If you're facing any problem on how to mark a checkbox, please read the following instructions:

  • Read a point one at a time and think if it is relevant to the pull request or not.
  • If it is, then mark it by putting a x between the square bracket like so: [x]

NOTE: Only [x] is supported so if you have put any other letter or symbol between the brackets, that will be marked as invalid. If that is the case then please open a new pull request with the appropriate changes.

@algorithms-keeper algorithms-keeper Bot added the awaiting reviews This PR is ready to be reviewed label Apr 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviews This PR is ready to be reviewed invalid

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant