Add thread-safe queue implementation#7388
Open
Senrian wants to merge 2 commits intoTheAlgorithms:masterfrom
Open
Add thread-safe queue implementation#7388Senrian wants to merge 2 commits intoTheAlgorithms:masterfrom
Senrian wants to merge 2 commits intoTheAlgorithms:masterfrom
Conversation
Issue TheAlgorithms#7356: Add null check for the search value to prevent potential NullPointerException.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7388 +/- ##
============================================
- Coverage 79.45% 79.37% -0.09%
- Complexity 7083 7179 +96
============================================
Files 790 799 +9
Lines 23164 23521 +357
Branches 4556 4623 +67
============================================
+ Hits 18405 18669 +264
- Misses 4022 4108 +86
- Partials 737 744 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Nice work on the implementation! I was planning to start working on this after opening the issue, but great to see it already in progress. If you're okay with it, I can contribute by adding test cases to strengthen the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a simple thread-safe queue implementation (
ThreadSafeQueue) to the data structures directory.This implementation uses the
synchronizedkeyword on methods to ensure thread safety, as requested in issue #7387.Features:
synchronizedkeywordenqueue,dequeue,peek,isEmpty,sizeIterable<T>for enhanced usabilityImplementation details:
Node<T>class for linked list nodesNoSuchElementExceptionwhen dequeuing/peeking from empty queueIllegalArgumentExceptionwhen enqueueing null dataFixes #7387
Type of Change
Checklist: