Create Longest_Substring_Without_Repeating_Characters.cpp#2761
Merged
realstealthninja merged 17 commits intoTheAlgorithms:masterfrom Oct 10, 2024
Merged
Create Longest_Substring_Without_Repeating_Characters.cpp#2761realstealthninja merged 17 commits intoTheAlgorithms:masterfrom
realstealthninja merged 17 commits intoTheAlgorithms:masterfrom
Conversation
* I would like to contribute for sliding window algorithm and this one is one of the famous problem that is asked in interviews. * Thank you!!.
ashish5kmax
requested review from
Panquesito7 and
realstealthninja
as code owners
…to sliding-window/Longest_Substring_Without_Repeating_Characters.cpp * This is my contribution towards the sliding window algorithm/s and this is one of the famous problems. * Thank you.
* I would like to contribute towards the sliding window algorithm in which this is one of the famous problem asked in interviews. * Thank you.
* Updated certain changes in documentation, this is my contribution towards sliding window algorithm this is one of the famous interview problem. * Thank you.
* Well documented and tested code for sliding window algorithm. * Thank you.
Collaborator
|
Unfortunately we dont currently accept leetcode solutions see #2450 |
realstealthninja
added
not-an-algorithm
Contributor
Author
|
what if I put these under the other section will that be fine |
Collaborator
yes but use a proper class instead of the solution one you've used |
…to Longest_Substring_Without_Repeating_Characters.cpp * So,I did a small change I added the problem into the others section I think this works fine I guess. * I would be glad if this can be tagged as hackoctoberfest * Thank you.
realstealthninja
requested changes
Oct 5, 2024
…to longest_substring_without_repeating_characters.cpp * I hope I have done the required changes.
* Added specific edge cases and tests as void tests() and followed the guidelines.
realstealthninja
requested changes
Oct 5, 2024
* I hope I have made the necessary changes required. * If there are any changes to make I can do that. * Thank you.
Contributor
Author
|
realstealthninja
requested changes
Oct 7, 2024
* I have done the required changes for the include part. * Thank you.
realstealthninja
requested changes
Oct 7, 2024
Contributor
Author
|
Contributor
Author
|
any updates. |
Contributor
Author
|
realstealthninja
approved these changes
Oct 9, 2024
Collaborator
realstealthninja
left a comment
realstealthninja
left a comment
There was a problem hiding this comment.
LGTM! Thank you so much for this contribution.
realstealthninja
added
approved
Contributor
Author
|
Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would like to help you by adding sliding window algorithms one of them is a famous question asked in interviews that is "Longest Substring Without Repeating Characters".
I hope this helps the community.
Thank you.
Description of Change
Checklist
Notes: