update sta bazel runfile skip and openroad's claude.md to relax sta c…#10224
Conversation
…hange Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the documentation in AGENTS.md to relax the restriction on modifying src/sta/ files and updates the src/sta submodule reference. A review comment suggests retaining the architectural context regarding preferred locations for fixes, such as src/dbSta/ or src/rsz/, to provide better guidance for AI agents.
| ## Critical Rules | ||
|
|
||
| 1. **Never modify `src/sta/` files** -- OpenSTA is managed upstream (`Sdc.cc`, `Power.cc`, `Sdc.tcl`, etc.). **Only test files may be modified.** All fixes must be in OpenROAD code (e.g., `src/dbSta/`, `src/rsz/`). If OpenSTA code change is inevitable, notify user. Exception: you *may* modify `src/sta/` files temporarily for **debugging purposes** only. | ||
| 1. **Ask before modifying `src/sta/` files** -- OpenSTA is managed upstream (`Sdc.cc`, `Power.cc`, `Sdc.tcl`, etc.). |
There was a problem hiding this comment.
While relaxing the restriction on modifying src/sta/ files, removing the guidance on where fixes should ideally be placed (e.g., src/dbSta/ or src/rsz/) loses valuable architectural context for the AI agent. Retaining this information helps the agent suggest more appropriate solutions before defaulting to submodule modifications.
| 1. **Ask before modifying `src/sta/` files** -- OpenSTA is managed upstream (`Sdc.cc`, `Power.cc`, `Sdc.tcl`, etc.). | |
| 1. Ask before modifying src/sta/ files -- OpenSTA is managed upstream (Sdc.cc, Power.cc, Sdc.tcl, etc.). Prefer fixes in OpenROAD code (e.g., src/dbSta/, src/rsz/) when possible. |
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
3 participants
Update OpenROAD with latest STA (the pointer didnt get updated post merge in sta) and relax claude.md to let me develop in src/sta
Summary
update sta pointer to OpenSTA master and relax CLAUDE.md
Type of Change
Impact
No need to have runfiles in bazel now
Verification
./etc/Build.sh).Related Issues
[Link issues here]