cts: avoid loop in clock gate cloning recursion#10163
Open
openroad-ci wants to merge 2 commits intoThe-OpenROAD-Project:masterfrom
Open
cts: avoid loop in clock gate cloning recursion#10163openroad-ci wants to merge 2 commits intoThe-OpenROAD-Project:masterfrom
openroad-ci wants to merge 2 commits intoThe-OpenROAD-Project:masterfrom
Conversation
Signed-off-by: arthurjolo <arthurjl@precisioninno.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces cycle detection in the clock gate cloning process within the TritonCTS module. By passing a set of visited nets through the recursive calls of cloneClockGaters, the implementation now prevents potential infinite loops when traversing clock nets. I have no feedback to provide as there were no review comments to evaluate.
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
|
Running a CI to ensure everything is fine. |
Contributor
|
Ci is finishing with no differences. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
If there are loops in the clock tree clock gate cloning could get stuck in an recursion loop causing a crash. This PR prevents this loop and the crash
Type of Change
Impact
Prevent loops during clock gate cloning search for clock gaters.
Verification
./etc/Build.sh).Related Issues
issue #9993