dpl/dpo: rework metrics#10160
Open
gudeh wants to merge 10 commits intoThe-OpenROAD-Project:masterfrom
Open
Conversation
including counters for number of intermediate and final moves Signed-off-by: Augusto Berndt <augusto.berndt@precisioninno.com>
Signed-off-by: Augusto Berndt <augusto.berndt@precisioninno.com>
include DPO nominal HPWL diff as metric Signed-off-by: Augusto Berndt <augusto.berndt@precisioninno.com>
Signed-off-by: Augusto Berndt <augusto.berndt@precisioninno.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request enhances placement analysis by introducing move and attempt tracking across legalization and optimization passes. It refactors reporting logic to include detailed displacement statistics and relocated cell counts, while also updating metric names for better consistency. Review feedback focuses on improving code robustness and style by explicitly including the header, using the std::round function, and standardizing DPO metric names to match the updated DPL naming convention.
Signed-off-by: Augusto Berndt <augusto.berndt@precisioninno.com>
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR includes new metrics for DPL and DPO, including:
detailedplace__dpl__legalizer__type).detailedplace__dpl__total__moves).detailedplace__dpo__total__attempts).detailedplace__dpo__relocated__cells).I renamed a few existing metrics, such as from
detailedplace__design__instance__displacement__totaltodetailedplace__dpl__instance__displacement__totalHere is the final result, comparing to master (left):

Type of Change
Impact
no-op
Verification
./etc/Build.sh).