DRT: handle guides below the bottom routing layer#10157
Conversation
Signed-off-by: osamahammad21 <osama21@aucegypt.edu>
Signed-off-by: osamahammad21 <osama21@aucegypt.edu>
Signed-off-by: osamahammad21 <osama21@aucegypt.edu>
Signed-off-by: osamahammad21 <osama21@aucegypt.edu>
Signed-off-by: osamahammad21 <osama21@aucegypt.edu>
There was a problem hiding this comment.
Code Review
This pull request introduces the DBPROCESSNODE configuration, specifically adding logic to handle 'ISPD' nodes within the guide processing stage. It enables a previously disabled validation check for non-ISPD nodes and adjusts the guide splitting logic to conditionally skip rectangle additions based on the layer and node type. Corresponding test cases have been updated to include the new parameter. A review comment identifies a redundant logical condition in GuideProcessor.cpp that could be simplified for better clarity.
Signed-off-by: osamahammad21 <osama21@aucegypt.edu>
Signed-off-by: osamahammad21 <osama21@aucegypt.edu>
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
Why not change the min routing layer for ispd if there are long guides on m1? |
Signed-off-by: osamahammad21 <osama21@aucegypt.edu>
Signed-off-by: osamahammad21 <osama21@aucegypt.edu>
Signed-off-by: osamahammad21 <osama21@aucegypt.edu>
Signed-off-by: osamahammad21 <osama21@aucegypt.edu>
Signed-off-by: osamahammad21 <osama21@aucegypt.edu>
|
clang-tidy review says "All clean, LGTM! 👍" |
maliberty
left a comment
There was a problem hiding this comment.
I'll leave it to you to clean the CI issues and merge
|
@sombraSoft @vvbandeira macOS build fails for a download failure: |
|
I re-ran it twice and it then passed. Must have been some transient failure on the remote |
|
clang-tidy review says "All clean, LGTM! 👍" |

Summary
In a test case, GuidesProcessor generated a long guide below the bottom routing layer which caused a mazerouteError. In this PR, I allow only via guides below the bottom routing layer except for ISPD designs which use long guides on M1.
Type of Change
Impact
Very minor indirect changes in the final result.
Verification
./etc/Build.sh).