Possible fix for issue #2770.#2828
Open
darksonic300 wants to merge 1 commit intoThe-Aether-Team:1.21.1-developfrom
Open
Possible fix for issue #2770.#2828darksonic300 wants to merge 1 commit intoThe-Aether-Team:1.21.1-developfrom
darksonic300 wants to merge 1 commit intoThe-Aether-Team:1.21.1-developfrom
Conversation
|
Did this Fix the issue? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on errors of various users, and a brief code analysis, the cause of issue #2770 could be related to the MoaType CODEC retrieval somehow failing to read the egg item, as if the item didn't exist.
I changed the codec definition to be lazy initialized, with a fallback Vanilla egg, so that players should supposedly still be able to join servers that find themselves in such a situation.
I couldn't test the fix as I cannot recreate the conditions of the issue. This means it might not be enough to resolve it.
I agree to the Contributor License Agreement (CLA).