Skip to content

fix(cache): #25955 - invalidate model on reordering action #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
timotejSinicak wants to merge 1 commit into from
+9 −0
Closed

fix(cache): #25955 - invalidate model on reordering action #127

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/django_smartbase_admin/engine/admin_base_view.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,6 +371,11 @@ def is_reorder_available(self, request) -> str | None:

@sbadmin_action
def action_table_reorder(self, request, modifier) -> JsonResponse:
try:
from cacheops import invalidate_model
except ImportError:
invalidate_model = None

self.activate_reorder(request)
qs = self.get_queryset(request)
pk_field = SBAdminViewService.get_pk_field_for_model(self.model).name
Expand Down Expand Up @@ -402,6 +407,10 @@ def action_table_reorder(self, request, modifier) -> JsonResponse:
+ int(diff)
}
)

# Ensure fresh ordering after reorder for cacheops-managed models.
if invalidate_model:
invalidate_model(self.model)
return JsonResponse({"message": request.POST})

@sbadmin_action
Expand Down
Loading