Conversation
|
@lassoan could you please evaluate this PR as well? |
|
There is no CLI modules, so you cannot ask the user about installing a Python package. It is OK to install without asking, like this: I could not try to actually use any of the modules, because I could not find any tutorial with testing data. |
|
Great, @lassoan BTW, I have also added a small data test zip file here to assist with a (brief) testing. |
|
@lassoan , just to say that I have updated the extension documentation to give a quick dataset tutorial to assist for further testing. I already included the I hope that this will be useful for the general community. Any thoughts are very welcome! BTW, thank you very much for all the help! |
|
Thank you for your patience. Have you tried if |
|
Hi @lassoan Thank you for the suggestion. I made the change in the print messages, using the direct standard output. All the Is there anything else to be adjusted? Thank you again for all the tips! |
1025ee1 to
cfc11b2
Compare
cfc11b2 to
e76ac4e
Compare
e76ac4e to
0b8ce19
Compare
|
Hi @jcfr I am wondering if it is needed to ajust more details in the PR. Please tell me what are the further adjustments to be done (if there is any). Thank you! |
8464efc to
b7fe5eb
Compare
|
It should be good, only the extension name and category needs some attention. ❌ Check extension name failed: extension name should not start with 'Slicer'. Please, consider changing it to '_ASLtoolkit'. Could you update the project name in the top-level CMakeLists.txt file to be ❌ Check category failed: Category Arterial Sping Labelling is unknown. Consider using any of the known extensions instead: Active Learning, Analysis, Auto3dgm, BigImage, Cardiac, Chest Imaging Platform, Conda, Converters, DICOM, DSCI, Developer Tools, Diffusion, Examples, Exporter, FTV Segmentation, Filtering, Filtering.Morphology, Filtering.Vesselness, Holographic Display, IGT, Informatics, Netstim, Neuroimaging, Nuclear Medicine, Orthodontics, Osteotomy Planning, Otolaryngology, Photogrammetry, Pipelines, Planning, Printing, Quantification, Radiotherapy, Registration, Remote, Rendering, SPHARM, Segmentation, Sequences, Shape Analysis, Shape Regression, Shape Visualization, Simulation, SlicerCMF, SlicerMorph, Spectral Imaging, Supervisely, Surface Models, SurfaceLearner, Tomographic Reconstruction, Tracking, Tractography, Training, Ultrasound, Utilities, Vascular Modeling Toolkit, Virtual Reality, VisSimTools, Web System Tools, Wizards Would any of these existing categories work for your extension? |
b7fe5eb to
7f186be
Compare
7f186be to
e7915e8
Compare
Hi @lassoan Great, I will make the change in the extension name to remove the However, regarding the Thank you again for the revision in the PR and all the help! |
|
In the long term we should probably switch to using multiple "tags" to filter and categorize extensions. But for now, to make the single "category" field useful, we need categories that contain more than a few extensions, but not dozens. How many extensions could go into the "Arterial Spin Labeling" category? |
|
I see and agree with you @lassoan. In any case, considering that it is in the Slicer planning to add a multiple tag in the future, I could place an exisiting category now and then update it in the future. If this is good to go, I can make the adjsutment in the code here. Thanks! |
|
Hi, @lassoan I have made the changes in the extension name and category and CI have checked successfuly. Is anything else needed ? Thank you again for the support |
|
Thank you, everything looks good! Just a few things to consider:
|
New extension
3d-slicer-extensionGitHub topic so that it is listed here. To edit topics, click the settings icon in the right side of "About" section header and enter3d-slicer-extensionin "Topics" and click "Save changes". To learn more about topics, read https://help.github.com/en/articles/about-topicsSettingsand in repository settings uncheckWiki,Projects, andDiscussions(if they are currently not used)Aboutin the top-right corner of the repository main page and uncheckReleasesandPackages(if they are currently not used)