Add borderless window to ac2 (uplay edition)#21
Open
kirides wants to merge 2 commits intoSergeanur:masterfrom
Open
Add borderless window to ac2 (uplay edition)#21kirides wants to merge 2 commits intoSergeanur:masterfrom
kirides wants to merge 2 commits intoSergeanur:masterfrom
Conversation
…ion" function and doing the work at that point
990708e to
9089a33
Compare
|
Thank you for this PR! It looks like this repo is not maintained anymore. Could you please share the final version of your asi file? It will definetely help me and many others people |
Author
|
@FrostMoonEcho i don't have AC 1 and AC2 retail copies, the only thing i could implement because of this was the AC 2 uplay/ubisoft connect variant, and that one is linked in the opening comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This lets us play the game in borderless window mode (by default) and can be toggled off using BorderlessWindow=0 option in ini. It opens the way for a proper fix for #13
It works by hooking the call to the initialization method that creates the
IDirect3DDevice9.It sets the global
IsFullscreenflag to0and then it proceeds to grab primary screen metrics, remove borders from the window and resize the game window.attached is a pre-built version of the patch with the feature added.
EaglePatch_borderlesswindow_ac2_uplay.zip
It is missing the addresses for AC1 and the retail version of AC2 as i don't own those and dont like playing AC1
Also, a neat(?) side effect of the borderless window is, that DXVK now doesn't crash the game anymore (tested with DXVK 2.5 on windows 11)