Advisory device protection: implementation#12622
Merged
touilleMan merged 7 commits intomasterfrom Apr 21, 2026
Merged
Conversation
touilleMan
force-pushed
the
mandatory-totp-impl
branch
from
e968fe2 to
0205f2e
Compare
touilleMan
force-pushed
the
mandatory-totp
branch
from
d7123a1 to
35207be
Compare
touilleMan
force-pushed
the
mandatory-totp-impl
branch
3 times, most recently
from
c987f2f to
3bfe981
Compare
AureliaDolo
approved these changes
Apr 17, 2026
| assert!("DUMMY+TOTP" | ||
| .parse::<AdvisoryDeviceFileProtection>() | ||
| .is_err()); | ||
| assert!("".parse::<AdvisoryDeviceFileProtection>().is_err()); |
Contributor
There was a problem hiding this comment.
Suggested change
| assert!("".parse::<AdvisoryDeviceFileProtection>().is_err()); | |
| assert!("".parse::<AdvisoryDeviceFileProtection>().is_err()); | |
| assert!("TOTP+PASSWORD".parse::<AdvisoryDeviceFileProtection>().is_err()); |
| metavar="STRATEGY", | ||
| help="""Advisory device file protection to recommend to clients. | ||
|
|
||
| Can be specified multiple times to recommend multiple strategies. |
Contributor
There was a problem hiding this comment.
Just to be sure o specify password and keyring you'd have to do something like
--advisory-device-file-protection PASSWORD --advisory-device-file-protection KEYRING
or --advisory-device-file-protection PASSWORD,KEYRING would work ?
Contributor
Author
There was a problem hiding this comment.
Yes, the option has to be provided multiple times (we already do this for the --cors-allow-origins option)
Note when passing by environment variable, the value is cut by whitespaces
mmmarcos
approved these changes
Apr 20, 2026
touilleMan
force-pushed
the
mandatory-totp-impl
branch
from
3bfe981 to
590a5cf
Compare
…libparsec_protocol`
…command on server
touilleMan
force-pushed
the
mandatory-totp-impl
branch
from
590a5cf to
c519a93
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.