[MS] Update organization recovery page#12588
Merged
fabienSvtr merged 1 commit intomasterfrom Apr 20, 2026
Merged
Conversation
fabienSvtr
force-pushed
the
ms-organization-recovery-page
branch
2 times, most recently
from
b816537 to
00cbcd8
Compare
fabienSvtr
force-pushed
the
ms-organization-recovery-page
branch
from
d4d758f to
c73c724
Compare
Max-7
reviewed
Apr 13, 2026
Contributor
Max-7
left a comment
Max-7
left a comment
There was a problem hiding this comment.
You took the wrong path by replacing OrganizationRecoveryPage, and creating ExportRecoveryDeviceModal that's basically a copy of it. It makes the changes very hard to read (and therefor test and validate).
Instead, you should rename OrganizationRecoveryPage to DeviceRecoveryPage, add a DeviceRecoveryModal that basically just uses the DeviceRecoveryPage, and then add a new OrganizationRecoveryPage that groups everything (hoping that git will notice the renaming and not create diffs).
Max-7
reviewed
Apr 13, 2026
fabienSvtr
force-pushed
the
ms-organization-recovery-page
branch
3 times, most recently
from
80671a5 to
09314db
Compare
Ironicbay
requested changes
Apr 17, 2026
Ironicbay
approved these changes
Apr 17, 2026
| "adviceDone": "You have already created recovery files.", | ||
| "file": { | ||
| "title": "Recovery files", | ||
| "description": "A recovery file and a secret key allow you to regain access to your data once assembled.", |
Contributor
There was a problem hiding this comment.
Suggested change
| "description": "A recovery file and a secret key allow you to regain access to your data once assembled.", | |
| "description": "A recovery file combined with a secret key allow you to restore access to your data once assembled.", |
fabienSvtr
force-pushed
the
ms-organization-recovery-page
branch
from
c48a456 to
f669886
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #12566