fix: DynamicQuantities compatibility in core + differentiation paths#3126
Open
MilesCranmerBot wants to merge 6 commits intoSciML:masterfrom
Open
fix: DynamicQuantities compatibility in core + differentiation paths#3126MilesCranmerBot wants to merge 6 commits intoSciML:masterfrom
MilesCranmerBot wants to merge 6 commits intoSciML:masterfrom
Conversation
7 tasks
MilesCranmer
reviewed
Mar 8, 2026
Member
|
Rebase and add the lower bound |
|
@MilesCranmerBot please see comment above^ - can you rebase and add lower bound |
3c178aa to
ffed533
Compare
Author
|
Done — rebased onto current
I also ran |
2 tasks
Member
|
There are some CI failures to look at. |
ffed533 to
ad32cff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wave 2 (post-DynamicQuantities release) for the DynamicQuantities × SciML rollout.
Tracking issue: JuliaPhysics/DynamicQuantities.jl#200
What this changes
OrdinaryDiffEqCore
lib/OrdinaryDiffEqCore/test/dynamicquantities_measurements.jl)zero(::Type{<:Quantity})on runtime-unit quantity typesOrdinaryDiffEqDifferentiation
Notes
Local testing
julia --project=lib/OrdinaryDiffEqCore -e 'using Pkg; Pkg.test()'zero(::Type{<:Quantity})path).