feat: [AI] allow passing an operating point to linearize using a solution#4443
Open
AayushSabharwal wants to merge 4 commits intomasterfrom
Open
feat: [AI] allow passing an operating point to linearize using a solution#4443AayushSabharwal wants to merge 4 commits intomasterfrom
linearize using a solution#4443AayushSabharwal wants to merge 4 commits intomasterfrom
Conversation
AayushSabharwal
force-pushed
the
as/linearize-op
branch
from
c6fcf4f to
f9a6be1
Compare
baggepinnen
added a commit
to JuliaControl/ControlSystemsMTK.jl
that referenced
this pull request
Apr 13, 2026
Replace manual operating point extraction in `trajectory_ss` with MTK's `LinearizationOpPoint` API (SciML/ModelingToolkit.jl#4443). This removes the fragile `robust_sol_getindex` helper and simplifies the implementation. - Use `_build_op_from_solution` to extract differential states + parameters - Supplement with linearization system unknowns from the solution - Remove `robust_sol_getindex` (no longer needed) - Bump version to 2.7.0, require MTK >= 11.7 - Update docs narrative for trajectory_ss Closes SciML/ModelingToolkit.jl#4159 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
3 tasks
Contributor
|
I'm testing this PR from ControlSystemsMTK.jl and hit a dispatch ambiguity in The two methods are: # Method 1 (line 28): scalar
_build_op_from_solution(op::LinearizationOpPoint)
# Method 2 (line 44): vector
_build_op_from_solution(op::LinearizationOpPoint{S, <:AbstractVector}) where {S}Method 1 implicitly constrains |
AayushSabharwal
force-pushed
the
as/linearize-op
branch
from
f9a6be1 to
78da2e1
Compare
AayushSabharwal
force-pushed
the
as/linearize-op
branch
from
78da2e1 to
b63a43c
Compare
AayushSabharwal
force-pushed
the
as/linearize-op
branch
from
df97dab to
fbe0162
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #4159