Skip to content

Fix/source is single batch required #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pkumar-data wants to merge 2 commits into
base: main
Choose a base branch
from
+12 −2
Open

Fix/source is single batch required #448

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ed70b9
Make source_is_single_batch required in eff_sat_v0
pkumar-data Apr 9, 2026
1687fd2
Make source_is_single_batch required in eff_sat_v0
pkumar-data Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions macros/tables/eff_sat_v0.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{%- macro eff_sat_v0(yaml_metadata=none, source_model=none, tracked_hashkey=none, src_ldts=none, src_rsrc=none, is_active_alias=none, source_is_single_batch=true, disable_hwm=false, additional_columns=none) -%}
{%- macro eff_sat_v0(yaml_metadata=none, source_model=none, tracked_hashkey=none, src_ldts=none, src_rsrc=none, is_active_alias=none, source_is_single_batch=none, disable_hwm=false, additional_columns=none) -%}

{% set additional_columns_description = "
additional_columns::list | string Additional columns from source system or derived columns which should be part of the eff_sat.
Expand All @@ -11,7 +11,17 @@
{% set src_ldts = datavault4dbt.yaml_metadata_parser(name='src_ldts', yaml_metadata=yaml_metadata, parameter=src_ldts, required=False, documentation='Name of the loaddate column in the source model. Optional.') %}
{% set src_rsrc = datavault4dbt.yaml_metadata_parser(name='src_rsrc', yaml_metadata=yaml_metadata, parameter=src_rsrc, required=False, documentation='Name of the record source column in the source model. Optional.') %}
{% set is_active_alias = datavault4dbt.yaml_metadata_parser(name='is_active_alias', yaml_metadata=yaml_metadata, parameter=is_active_alias, required=False, documentation='Name of the new active flag column. Optional.') %}
{% set source_is_single_batch = datavault4dbt.yaml_metadata_parser(name='source_is_single_batch', yaml_metadata=yaml_metadata, parameter=source_is_single_batch, required=False, documentation='Whether the source contains only one batch. Optional, default True.') %}
{% set source_is_single_batch = datavault4dbt.yaml_metadata_parser(name='source_is_single_batch', yaml_metadata=yaml_metadata, parameter=source_is_single_batch, required=True, documentation='REQUIRED: Whether the source contains only one batch. Must be defined explicitly (true/false).') %}

{% if source_is_single_batch is none %}
{% do exceptions.raise_compiler_error(
"Missing required parameter 'source_is_single_batch' in eff_sat_v0. "
~ "Please define it explicitly as true or false. "
~ "true = source contains only one batch; false = multiple batches. "
~ "Example: source_is_single_batch: true"
) %}
{% endif %}

{% set disable_hwm = datavault4dbt.yaml_metadata_parser(name='disable_hwm', yaml_metadata=yaml_metadata, parameter=disable_hwm, required=False, documentation='Whether the High Water Mark should be disabled or not. Optional.') %}
{%- set additional_columns = datavault4dbt.yaml_metadata_parser(name='additional_columns', yaml_metadata=yaml_metadata, parameter=additional_columns, required=False, documentation=additional_columns_description) -%}

Expand Down