Open
Conversation
Run an ansible-lint check on the deployer to catch any ansible syntax errors is the deploy roles and plays before running them. Copy the ansible lint rules from ardana-dev-tools. Jira: SCRD-4907
One of the scripts ported from ardana-dev-tools had incorrect indentation, it has now been fixed.
In order to make the linting role safe to run in parallel with other tasks that may make changes to the git trees we are linting, make a copy of the target ansible path and run the linting against that.
In order to move the linting to its own role, the ardana_deploy role is being split in half so that the new role can be called in the middle.
This allows us to also put the linting into a separate stage.
| tasks: | ||
| - block: | ||
| - include_role: | ||
| name: ardana_lint |
Contributor
There was a problem hiding this comment.
Will the lint rules be removed from ardana-dev-tools, it might be better to not have two copies that need to be kept in sync?
Contributor
Author
There was a problem hiding this comment.
That'd be a good thing to do as a follow up to this in the ci-squad. I'm not sure if it'd be better to remove or find a path to keep them in sync so that likely needs some thought.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ansible linting to the pipeline workflow.